Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm side effects + add docstring to get_escalations #299

Merged
merged 1 commit into from
Aug 14, 2024
Merged

rm side effects + add docstring to get_escalations #299

merged 1 commit into from
Aug 14, 2024

Conversation

adhil0
Copy link
Collaborator

@adhil0 adhil0 commented Aug 14, 2024

Remove side effects (see #274) and add docstring to get_escalations()

@adhil0 adhil0 requested a review from dcritch August 14, 2024 00:37
dcritch
dcritch approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@dcritch dcritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, this aligns with our plan to avoid having some functions get data by calling others directly. lgtm!

@dcritch dcritch merged commit 4eb3b66 into RHsyseng:main Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcritch dcritch dcritch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhil0 @dcritch